🎨 [Frontend] Prettify Project card #7830
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeimaiz
added
t:enhancement
|
odeimaiz
requested review from
GitHK,
Copilot,
giancarloromeo,
matusdrobuliak66,
pcrespov and
sanderegg
Member
Author
|
@Mergifyio queue |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR improves the aesthetics and layout of the Project Info card by compacting the display and removing unused classifiers and TSR information. Key changes include:
- Updating default texts for missing descriptions and tags.
- Refactoring layout logic in study and service info components.
- Removing unused label texts and updating UI properties in confirmation dialogs and application metadata.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| services/static-webserver/client/source/class/osparc/info/StudyUtils.js | Updates to description and tags texts and major refactoring of layout handling |
| services/static-webserver/client/source/class/osparc/info/StudyLarge.js | Removal of redundant label texts for a cleaner UI |
| services/static-webserver/client/source/class/osparc/info/ServiceUtils.js | Adjustments to author display with added wrapping and maxWidth |
| services/static-webserver/client/source/class/osparc/info/ServiceLarge.js | Removal of classifiers and quality details for streamlined view |
| services/static-webserver/client/source/class/osparc/desktop/MainPage.js | Updated confirmation window properties for improved UX |
| services/static-webserver/client/compile.json | Updated application title to reflect new version |
Comments suppressed due to low confidence (2)
services/static-webserver/client/source/class/osparc/info/StudyUtils.js:335
- The method __titleWithEditLayout has been removed, but it is still referenced here. Either reinstate the method or update this branch of the code to use the new layout creation logic.
const titleLayout = this.__titleWithEditLayout(extraInfo);
services/static-webserver/client/source/class/osparc/desktop/MainPage.js:118
- [nitpick] Verify that the added confirmAction property is supported by the Confirmation widget and consistent with the design guidelines. Adding a brief inline comment to explain its purpose would improve code clarity.
const win = new osparc.ui.window.Confirmation().set({ confirmAction: "warning", });
Contributor
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 88e5a7a |
matusdrobuliak66
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
This PR prettifies the Project Info card, compacting the information and using more the horizontal space, avoiding scroll bars and also removing the classifiers and TSR info (they already have their unused section)
Before/After (write access):
Before/After (read access):
Related issue/s
How to test
Dev-ops